Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(isIdentityCard): fix listed locales #2340

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

breadadams
Copy link

Removed the MZ locale from the list of allowed locales for isIdentityCard, since a validation method has never been added for said locale.

It was added in #1604, presumably by mistake.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (c25b98f) to head (700ded3).
Report is 15 commits behind head on master.

Current head 700ded3 differs from pull request most recent head c4a144f

Please upload reports for the commit c4a144f to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #2340      +/-   ##
===========================================
- Coverage   100.00%   99.95%   -0.05%     
===========================================
  Files          109      107       -2     
  Lines         2489     2449      -40     
  Branches       628      619       -9     
===========================================
- Hits          2489     2448      -41     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

WikiRik
WikiRik previously approved these changes Nov 20, 2023
@WikiRik
Copy link
Member

WikiRik commented Nov 20, 2023

Don't mind the failure of codecov/project. That is not due to your PR

rubiin
rubiin previously approved these changes May 12, 2024
@rubiin rubiin dismissed stale reviews from WikiRik and themself via c4a144f June 13, 2024 13:01
@@ -120,7 +120,11 @@ Validator | Description
**isHexColor(str)** | check if the string is a hexadecimal color.
**isHSL(str)** | check if the string is an HSL (hue, saturation, lightness, optional alpha) color based on [CSS Colors Level 4 specification][CSS Colors Level 4 Specification].<br/><br/>Comma-separated format supported. Space-separated format supported with the exception of a few edge cases (ex: `hsl(200grad+.1%62%/1)`).
**isIBAN(str, [, options])** | check if the string is an IBAN (International Bank Account Number).<br/><br/>`options` is an object which accepts two attributes: `whitelist`: where you can restrict IBAN codes you want to receive data from and `blacklist`: where you can remove some of the countries from the current list. For both you can use an array with the following values `['AD','AE','AL','AT','AZ','BA','BE','BG','BH','BR','BY','CH','CR','CY','CZ','DE','DK','DO','EE','EG','ES','FI','FO','FR','GB','GE','GI','GL','GR','GT','HR','HU','IE','IL','IQ','IR','IS','IT','JO','KW','KZ','LB','LC','LI','LT','LU','LV','MC','MD','ME','MK','MR','MT','MU','MZ','NL','NO','PK','PL','PS','PT','QA','RO','RS','SA','SC','SE','SI','SK','SM','SV','TL','TN','TR','UA','VA','VG','XK']`.
<<<<<<< docs/fix-listed-isIdentityCard-locales -- Incoming Change
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the merge conflict

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been meaning to, looks like @rubiin introduced that recently.

Will try to get to it over the weekend.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must have left that when I fixed the conflict from github UI :|

@profnandaa profnandaa added stale and removed ✅ LGTM labels Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants