Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch contains multiple improvements to the normalizeEmail function. In particular:
Previous options passed to "normalizeEmail" have been removed:
When running without options, the behaviour of this function is almost identical to before (except that now subaddresses are removed for more providers and not just GMail). However, I was not able to make this patch fully backwards-compatible, meaning that I was not able to ensure that the same results would come out with supporting the same legacy switches (I tried!). Because of that, "legacy" switches (such as "remove_dots") have simply been removed, and this patch is partly backwards-incompatible. However, I do strongly feel that it's a necessary step in the right direction, to allow adding more providers in the future in a coherent way.
PS: It's been a while since I submitted you PR's... Nice to be back :)