Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONFIG GET REPS2 multinode response isn't converted #2392

Open
Yury-Fridlyand opened this issue Oct 4, 2024 · 0 comments · May be fixed by #2381
Open

CONFIG GET REPS2 multinode response isn't converted #2392

Yury-Fridlyand opened this issue Oct 4, 2024 · 0 comments · May be fixed by #2381
Labels
bug Something isn't working

Comments

@Yury-Fridlyand
Copy link
Collaborator

Describe the bug

CONFIG GET REPS2 multinode response isn't converted

Expected Behavior

Should be converted

Current Behavior

isn't converted

Reproduction Steps

>>> import asyncio
>>>
>>> from glide import GlideClientConfiguration, GlideClusterClientConfiguration, NodeAddress, GlideClient, GlideClusterClient, AllNodes, ProtocolVersion
>>> config = GlideClusterClientConfiguration([NodeAddress("localhost", 7000)], protocol=ProtocolVersion.RESP2)
>>> client = await GlideClusterClient.create(config)
>>> await client.config_get(['tls*file'], AllNodes())
{b'127.0.0.1:7002': [b'tls-key-file', b'', b'tls-dh-params-file', b'', b'tls-client-key-file', b'', b'tls-client-cert-file', b'', b'tls-cert-file', b'', b'tls-ca-cert-file', b''], b'127.0.0.1:7004': [b'tls-dh-params-file', b'', b'tls-key-file', b'', b'tls-client-cert-file', b'', b'tls-client-key-file', b'', b'tls-ca-cert-file', b'', b'tls-cert-file', b''], b'127.0.0.1:7001': [b'tls-cert-file', b'', b'tls-dh-params-file', b'', b'tls-client-key-file', b'', b'tls-key-file', b'', b'tls-client-cert-file', b'', b'tls-ca-cert-file', b''], b'127.0.0.1:7003': [b'tls-cert-file', b'', b'tls-ca-cert-file', b'', b'tls-dh-params-file', b'', b'tls-key-file', b'', b'tls-client-cert-file', b'', b'tls-client-key-file', b''], b'127.0.0.1:7000': [b'tls-cert-file', b'', b'tls-dh-params-file', b'', b'tls-client-cert-file', b'', b'tls-key-file', b'', b'tls-client-key-file', b'', b'tls-ca-cert-file', b''], b'127.0.0.1:7005': [b'tls-ca-cert-file', b'', b'tls-client-cert-file', b'', b'tls-cert-file', b'', b'tls-dh-params-file', b'', b'tls-client-key-file', b'', b'tls-key-file', b'']}

Returned value is Dict[List[str]] instead of Dict[Dict[str]]

Possible Solution

No response

Additional Information/Context

No response

Client version used

1.1

Engine type and version

N/A

OS

Linux

Language

TypeScript, Python, Java

Language Version

N/A

Cluster information

No response

Logs

No response

Other information

No response

@Yury-Fridlyand Yury-Fridlyand added the bug Something isn't working label Oct 4, 2024
@Yury-Fridlyand Yury-Fridlyand linked a pull request Oct 4, 2024 that will close this issue
@Yury-Fridlyand Yury-Fridlyand linked a pull request Oct 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant