Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: adds Json value return type #1024

Closed
wants to merge 3 commits into from

Conversation

shohamazon
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shohamazon shohamazon requested a review from a team as a code owner February 22, 2024 15:22
@barshaul
Copy link
Collaborator

have you tried using redis-rs support for the json module?
https:/amazon-contributing/redis-rs/blob/c132727bb94cb5ec8a6df14053a154645aa1d0d1/README.md?plain=1#L159
so we wont need to implement a json parser

@shachlanAmazon
Copy link
Contributor

so we wont need to implement a json parser

+1. In general, you almost never want to implement a parser - someone, somewhere, wrote a library that does it better. Even if the redis-rs implementation isn't what we need, we could use some other ready-made crate.

@shohamazon
Copy link
Collaborator Author

closing this pr, with a decision to stick to the existing return type which is str.
for some languages (like Java) returning a Json object (map of lists and maps etc) is complicated.
we will add examples on how to convert the string representation of a json value to a json object in every wrapper.

@shohamazon shohamazon closed this Feb 28, 2024
@shohamazon shohamazon deleted the json_return_type branch September 23, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants