Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Fix typing #1203

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Python: Fix typing #1203

merged 1 commit into from
Apr 2, 2024

Conversation

barshaul
Copy link
Collaborator

@barshaul barshaul commented Apr 1, 2024

Resolves error on python3.8:

Traceback (most recent call last):
  File “client_example.py”, line 6, in <module>
    from glide import (
  File “/Users/daganh/Library/Python/3.8/lib/python/site-packages/glide/__init__.py”, line 11, in <module>
    from glide.async_commands.redis_modules import json
  File “/Users/daganh/Library/Python/3.8/lib/python/site-packages/glide/async_commands/redis_modules/json.py”, line 23, in <module>
    from glide.redis_client import TRedisClient
  File “/Users/daganh/Library/Python/3.8/lib/python/site-packages/glide/redis_client.py”, line 38, in <module>
    ) -> type[RequestError]:
TypeError: ‘type’ object is not subscriptable

@barshaul barshaul requested a review from a team as a code owner April 1, 2024 08:59
@barshaul barshaul merged commit 961aab5 into valkey-io:main Apr 2, 2024
6 checks passed
@barshaul barshaul deleted the fix_py branch April 2, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants