Python: Added SPOP command #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamazon
reviewed
Apr 10, 2024
shohamazon
reviewed
Apr 10, 2024
| member3 = get_random_string(5) | ||
| assert await redis_client.sadd(key, [member, member2, member3]) == 3 | ||
| assert await redis_client.spop_count(key, 4) == {member, member2, member3} | ||
|
|
There was a problem hiding this comment.
check that nothing left in the set
Co-authored-by: Shoham Elias <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
GilboaAWS
commented
Apr 11, 2024
shohamazon
requested changes
Apr 11, 2024
| member3 = get_random_string(5) | ||
| assert await redis_client.sadd(key, [member, member2, member3]) == 3 | ||
| assert await redis_client.spop_count(key, 4) == {member, member2, member3} | ||
|
|
GilboaAWS
force-pushed
the
spop_python
branch
4 times, most recently
from
363c844
to
8c549fa
Compare
shohamazon
reviewed
Apr 11, 2024
| #[test] | ||
| fn test_convert_spop_to_set_for_spop_count() { | ||
| assert!(matches!( | ||
| expected_type_for_cmd(redis::cmd("SPOP").arg("key1").arg("count")), |
There was a problem hiding this comment.
Suggested change
| expected_type_for_cmd(redis::cmd("SPOP").arg("key1").arg("count")), | |
| expected_type_for_cmd(redis::cmd("SPOP").arg("key1").arg("3")), |
shohamazon
reviewed
Apr 11, 2024
shohamazon
reviewed
Apr 11, 2024
shohamazon
reviewed
Apr 11, 2024
shohamazon
reviewed
Apr 11, 2024
shohamazon
reviewed
Apr 11, 2024
shohamazon
reviewed
Apr 11, 2024
Co-authored-by: Shoham Elias <[email protected]>
shohamazon
reviewed
Apr 11, 2024
shohamazon
reviewed
Apr 11, 2024
shohamazon
reviewed
Apr 11, 2024
Co-authored-by: Shoham Elias <[email protected]>
shohamazon
reviewed
Apr 11, 2024
Co-authored-by: Shoham Elias <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
Co-authored-by: Shoham Elias <[email protected]>
shohamazon
approved these changes
Apr 11, 2024
shohamazon
reviewed
Apr 11, 2024
shohamazon
reviewed
Apr 11, 2024
shohamazon
requested changes
Apr 11, 2024
Co-authored-by: Shoham Elias <[email protected]>
shohamazon
reviewed
Apr 14, 2024
shohamazon
approved these changes
Apr 14, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
Co-authored-by: Shoham Elias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.