Node: Add PFADD command.
#1317
Merged
Node: Add PFADD command.
#1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `PFADD` command. Signed-off-by: Yury-Fridlyand <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> * Update CHANGELOG.md Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Aaron <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Aaron <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
requested review from
aaron-congo,
jonathanl-bq,
alex-arzola-imp,
barshaul,
acarbonetto,
shohamazon,
SanHalacogluImproving and
ikolomi
shohamazon
reviewed
Apr 22, 2024
| @@ -27,7 +27,7 @@ type Context = { | |||
| client: RedisClient; | |||
| }; | |||
|
|
|||
| const TIMEOUT = 10000; | |||
| const TIMEOUT = 50000; | |||
There was a problem hiding this comment.
It is a total IT timeout, 10 sec is too low. Sometimes it runs longer and causes test failures.
Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Shoham Elias <[email protected]>
aaron-congo
reviewed
Apr 24, 2024
Signed-off-by: Yury-Fridlyand <[email protected]>
acarbonetto
approved these changes
Apr 24, 2024
Signed-off-by: Yury-Fridlyand <[email protected]>
aaron-congo
approved these changes
Apr 25, 2024
Elen-Ghulam
approved these changes
Apr 25, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Node: Add `PFADD` command. (#232) * Add `PFADD` command. Signed-off-by: Yury-Fridlyand <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> * Update CHANGELOG.md Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Aaron <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Aaron <[email protected]> * Apply suggestions from code review Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Shoham Elias <[email protected]> * PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Aaron <[email protected]> Co-authored-by: Shoham Elias <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
ref #1221
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.