Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Adds Sort command #1439

Merged
merged 24 commits into from
Jun 5, 2024
Merged

Python: Adds Sort command #1439

merged 24 commits into from
Jun 5, 2024

Commits on Jun 4, 2024

  1. Adds sort command to python

    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    7100a02 View commit details
    Browse the repository at this point in the history

  2. addressed Run isort . --profile black --check --diff

    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    2007242 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Yury-Fridlyand <[email protected]>
    @GilboaAWS @Yury-Fridlyand
    GilboaAWS and Yury-Fridlyand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    6e767a5 View commit details
    Browse the repository at this point in the history

  4. Addressed comments from PR

    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ef8e5b1 View commit details
    Browse the repository at this point in the history

  5. Changed SortOrder to OrderBy

    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8cb47fd View commit details
    Browse the repository at this point in the history

  6. Updated valkey path in links. 

    Co-authored-by: Shoham Elias <[email protected]>
    @GilboaAWS @shohamazon
    GilboaAWS and shohamazon committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    e295566 View commit details
    Browse the repository at this point in the history

  7. Removed pass from Transaction Class. 

    Co-authored-by: Shoham Elias <[email protected]>
    @GilboaAWS @shohamazon
    GilboaAWS and shohamazon committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0e65551 View commit details
    Browse the repository at this point in the history

  8. Fix Limit doc

    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    19ec536 View commit details
    Browse the repository at this point in the history

  9. Updated sort args doc.

    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    d1a5068 View commit details
    Browse the repository at this point in the history

  10. Fix return from function

    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    d8bd446 View commit details
    Browse the repository at this point in the history

  11. Addressed comments. Renamed store to destination fixed standalone cli… 

    …ent arg to RedisClient instead of TRedisClient.
    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    216123a View commit details
    Browse the repository at this point in the history

  12. Changed doc according to comments.

    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    4c86e52 View commit details
    Browse the repository at this point in the history

  13. Apply suggestions from code review 

    Co-authored-by: Aaron <[email protected]>
    @GilboaAWS @aaron-congo
    GilboaAWS and aaron-congo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    7e44dd9 View commit details
    Browse the repository at this point in the history

  14. Remove duplicated line 

    Co-authored-by: Aaron <[email protected]>
    @GilboaAWS @aaron-congo
    GilboaAWS and aaron-congo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    91f9157 View commit details
    Browse the repository at this point in the history

  15. Remove unused import of Tuple

    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    158ea71 View commit details
    Browse the repository at this point in the history

  16. Apply suggestions from code review 

    Co-authored-by: Aaron <[email protected]>
    @GilboaAWS @aaron-congo
    GilboaAWS and aaron-congo committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0807065 View commit details
    Browse the repository at this point in the history

  17. fixed tests.

    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    49a2bd4 View commit details
    Browse the repository at this point in the history

  18. Fixed doc.

    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c3649d5 View commit details
    Browse the repository at this point in the history

  19. Added tests that return None in a list.

    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    911ebdf View commit details
    Browse the repository at this point in the history

  20. Added entry in the CHANGELOG for SORT in python.

    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    215140d View commit details
    Browse the repository at this point in the history

  21. Update python/python/glide/async_commands/command_args.py

    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    6f214f2 View commit details
    Browse the repository at this point in the history

  22. Added entry in the CHANGELOG for SORT in python.

    @GilboaAWS
    GilboaAWS committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    952e0e0 View commit details
    Browse the repository at this point in the history

  23. Update CHANGELOG.md 

    Co-authored-by: Yury-Fridlyand <[email protected]>
    @GilboaAWS @Yury-Fridlyand
    GilboaAWS and Yury-Fridlyand authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    dd4cac3 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Updated Cluster's Transaction's Sort response to non None value. 

    Co-authored-by: Yury-Fridlyand <[email protected]>
    @GilboaAWS @Yury-Fridlyand
    GilboaAWS and Yury-Fridlyand authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    f89eadc View commit details
    Browse the repository at this point in the history