Python: adds HSTRLEN command #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamazon
force-pushed
the
python/hstrlen
branch
from
e7a4dd7
to
b7038b5
Compare
Yury-Fridlyand
approved these changes
Jun 13, 2024
acarbonetto
approved these changes
Jun 18, 2024
| @@ -838,7 +838,7 @@ async def hget(self, key: str, field: str) -> Optional[str]: | |||
| Returns None if `field` is not presented in the hash or `key` does not exist. | |||
|
|
|||
| Examples: | |||
| >>> await client.hset("my_hash", "field") | |||
| >>> await client.hset("my_hash", "field", "value") | |||
| assert await redis_client.hset(key, {"field": "value"}) == 1 | ||
| assert await redis_client.hstrlen(key, "field") == 5 | ||
|
|
||
| assert await redis_client.hstrlen(key, "field2") == 0 |
There was a problem hiding this comment.
not sure why you have this test, since you're already testing the non-existing field case on line 873
There was a problem hiding this comment.
line 873 is for non-existing key, I think it's nice to have both
acarbonetto
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 18, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 19, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.