Python: adds LSET command #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
approved these changes
Jun 17, 2024
| @@ -1415,6 +1415,33 @@ async def lindex( | |||
| await self._execute_command(RequestType.LIndex, [key, str(index)]), | |||
| ) | |||
|
|
|||
| async def lset(self, key: str, index: int, element: str) -> TOK: | |||
There was a problem hiding this comment.
Some commands return TOK, some - str, even though they return only OK.
What is the client standard?
There was a problem hiding this comment.
TOK is just a python way for making the literal OK a type, it's the same as str but for commands that only returns OK
acarbonetto
approved these changes
Jun 18, 2024
acarbonetto
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 18, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 19, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.