Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Added FUNCTION DELETE command #1591

Closed
wants to merge 2 commits into from

Conversation

shohamazon
Copy link
Collaborator

Issue #, if available:

Description of changes:
this PR is rebased over #1589

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shohamazon shohamazon requested a review from a team as a code owner June 17, 2024 14:55
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be ready for merge conflicts

python/python/glide/async_commands/cluster_commands.py Outdated Show resolved Hide resolved
python/python/glide/async_commands/cluster_commands.py Outdated Show resolved Hide resolved
python/python/glide/async_commands/standalone_commands.py Outdated Show resolved Hide resolved
@@ -4755,3 +4858,5 @@ async def test_script(self, redis_client: TRedisClient):
script = Script("return redis.call('GET', KEYS[1])")
assert await redis_client.invoke_script(script, keys=[key1]) == "value1"
assert await redis_client.invoke_script(script, keys=[key2]) == "value2"

assert await redis_client.invoke_script(script, keys=[key2]) == "value2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? a mistake?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably 😶

python/python/tests/test_async_client.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming a comment from previous review is fixed

@yipin-chen
Copy link
Collaborator

Closing this PR, as the commits have been pulled into #1714

@yipin-chen yipin-chen closed this Jun 29, 2024
@shohamazon shohamazon deleted the python/function-delete branch September 23, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants