Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Add command GetEX #1612

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Conversation

tjzhang-BQ
Copy link
Collaborator

  • Python: Add command GetEx

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner June 19, 2024 22:11
* Python: Add command GetEx
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test using PERSIST

CHANGELOG.md Outdated
@@ -39,6 +39,8 @@
* Python: Added SETBIT command ([#1571](https:/aws/glide-for-redis/pull/1571))
* Python: Added SRandMember command ([#1578](https:/aws/glide-for-redis/pull/1578))
* Python: Added GETBIT command ([#1575](https:/aws/glide-for-redis/pull/1575))
* Python: Added GETEX command ([#0000](https:/aws/glide-for-redis/pull/TODOLINK))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Python: Added GETEX command ([#0000](https:/aws/glide-for-redis/pull/TODOLINK))
* Python: Added GETEX command ([#1612](https:/aws/glide-for-redis/pull/1612))

glide-core/src/protobuf/redis_request.proto Outdated Show resolved Hide resolved
python/python/tests/test_async_client.py Show resolved Hide resolved
@acarbonetto acarbonetto merged commit 50e5ff3 into valkey-io:main Jun 19, 2024
46 checks passed
@acarbonetto acarbonetto deleted the python/integ_tjz_getex branch June 19, 2024 23:08
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
* Add Python cmd GetEX

* Python: Add command GetEx

* addressing comments & updating changelog

* changelog & request type

---------

Co-authored-by: TJ Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants