Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: add XREVRANGE command #1625

Merged
merged 4 commits into from
Jun 22, 2024

Conversation

aaron-congo
Copy link
Collaborator

@aaron-congo aaron-congo commented Jun 21, 2024

Issue #, if available:
N/A

Description of changes:
https://redis.io/docs/latest/commands/xrevrange/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aaron-congo aaron-congo requested a review from a team as a code owner June 21, 2024 22:18

Returns:
Optional[Mapping[str, List[List[str]]]]: A mapping of stream IDs to stream entry data, where entry data is a
list of pairings with format `[[field, entry], [field, entry], ...]`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add:

Returns `null` if the range arguments aren't applicable. 

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to xrange too then

@acarbonetto acarbonetto merged commit c921f13 into valkey-io:main Jun 22, 2024
6 checks passed
@acarbonetto acarbonetto deleted the python/integ_acongo_xrevrange branch June 22, 2024 04:47
jduo pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 28, 2024
* Python: add XREVRANGE command

* Update doc for xrevrange

Signed-off-by: Andrew Carbonetto <[email protected]>

* Update transaction docs

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Andrew Carbonetto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants