Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: add XGROUP CREATECONSUMER and XGROUP DELCONSUMER commands #1658

Conversation

aaron-congo
Copy link
Collaborator

@aaron-congo aaron-congo commented Jun 25, 2024

Issue #, if available:
N/A

Description of changes:
https://redis.io/docs/latest/commands/xgroup-createconsumer/
https://redis.io/docs/latest/commands/xgroup-delconsumer/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aaron-congo aaron-congo requested a review from a team as a code owner June 25, 2024 19:21
python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved
python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved
python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved
python/python/glide/async_commands/core.py Outdated Show resolved Hide resolved
python/python/glide/async_commands/transaction.py Outdated Show resolved Hide resolved
python/python/glide/async_commands/transaction.py Outdated Show resolved Hide resolved
python/python/glide/async_commands/transaction.py Outdated Show resolved Hide resolved
python/python/glide/async_commands/transaction.py Outdated Show resolved Hide resolved
== 0
)

# TODO: use XREADGROUP to mark pending messages for the consumer so that we get non-zero return
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

@acarbonetto acarbonetto merged commit 04e15d0 into valkey-io:main Jun 25, 2024
6 checks passed
@acarbonetto acarbonetto deleted the python/integ_acongo_xgroup_createconsumer_delconsumer branch June 25, 2024 21:05
jduo pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 28, 2024
…lkey-io#1658)

* Python: add XGROUP CREATECONSUMER and XGROUP DELCONSUMER commands

* Rename consumer variable to consumer_name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants