Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Rename RedisClient, RedisClusterClient to GlideClient, GlideClusterClient #1669

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

shohamazon
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shohamazon shohamazon changed the title [WIP] Draft - Python Rename RedisClient to GlideClient Python: Rename RedisClient to GlideClient Jun 26, 2024
@shohamazon shohamazon marked this pull request as ready for review June 26, 2024 13:10
@shohamazon shohamazon requested a review from a team as a code owner June 26, 2024 13:10
@shohamazon shohamazon requested a review from barshaul June 26, 2024 13:10
@shohamazon shohamazon changed the title Python: Rename RedisClient to GlideClient Python: Rename RedisClient, RedisClusterClient to GlideClient, GlideClusterClient Jun 26, 2024
@Yury-Fridlyand
Copy link
Collaborator

Yury-Fridlyand commented Jun 26, 2024

Why?
Please, add changelog entry - it is a breaking change (unless you keep exporting class aliases with old names for legacy compatibility).

@Yury-Fridlyand Yury-Fridlyand added the breaking breaking changes label Jun 26, 2024
@shohamazon shohamazon merged commit 7b6b220 into valkey-io:main Jun 27, 2024
6 checks passed
@shohamazon shohamazon deleted the glide_client branch June 27, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking breaking changes python
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants