Python: add XGROUP SETID command #1683
Conversation
aaron-congo
force-pushed
the
python/integ_acongo_xgroup_setid
branch
from
e9d2dac
to
52263e1
Compare
aaron-congo
changed the title
| entries_read_id (Optional[str]): An arbitrary ID (that isn't the first ID, last ID, or the zero ID ("0-0")) | ||
| used to find out how many entries are between the arbitrary ID (excluding it) and the stream's last | ||
| entry. This argument can only be specified if you are using Redis version 7.0.0 or above. |
There was a problem hiding this comment.
As more I read this, as less I understand it.
No complains to you, you just copied the doc. Do you understand how it changes the command behavior?
There was a problem hiding this comment.
Yeah this is pretty hard to understand from the existing Redis docs. I think this is relevant to the XINFO GROUPS command. If I understand correctly, you can pass this to tell Redis what the last entry received was for the consumer group. Then when you execute XINFO GROUPS it can return this info to you, as well as a count of how many messages have arrived since the indicated entries_read_id
| # reset the last delivered ID for the consumer group to "1-1" | ||
| # ENTRIESREAD is only supported in Redis version 7.0.0 and above | ||
| if await check_if_server_version_lt(redis_client, "7.0.0"): | ||
| assert await redis_client.xgroup_set_id(key, group_name, stream_id1_1) == OK |
There was a problem hiding this comment.
Is there a separate command to call to test that ENTRIESREAD has an affects the group?
There was a problem hiding this comment.
I think XINFO GROUPS, we can probably test this once that gets implemented
| # XGROUP SETID accepts "0" for the entries read ID, but does not accept "0-0" | ||
| with pytest.raises(RequestError): | ||
| await redis_client.xgroup_set_id( | ||
| key, group_name, stream_id1_1, entries_read_id="0-0" |
There was a problem hiding this comment.
maybe change this:
| key, group_name, stream_id1_1, entries_read_id="0-0" | |
| key, group_name, stream_id1_1, entries_read_id="stream_id0" |
since the documentation says it cannot be the first or zero entry.
There was a problem hiding this comment.
stream_id0 is equal to "0". Oddly enough, "0" is accepted for the entries_read_id but "0-0" is not. Strangely, "1-1" is not accepted either, even though it is not the first, last, or zero ID. It seems as though it only accepts IDs that don't have a dash. I tested this with Redis CLI as well. I'll just change this to stream_id1_0 for now since it is the first entry, even though it also won't accept "1-1"
aaron-congo
force-pushed
the
python/integ_acongo_xgroup_setid
branch
from
c80ea9d
to
7e5d9d6
Compare
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/xgroup-setid/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.