Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Add SSCAN and ZSCAN commands #1705

Merged
merged 51 commits into from
Jun 29, 2024
Merged

Java: Add SSCAN and ZSCAN commands #1705

merged 51 commits into from
Jun 29, 2024

Commits on Jun 29, 2024

  1. Java: Add SSCAN command (#394) 

    * Add ScanOptions base class for scan-family options.
* Expose the cursor as a String to support unsigned 64-bit cursor values.

Co-authored-by: James Duong <[email protected]>
    @GumpacG @jduo
    GumpacG and jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    3916278 View commit details
    Browse the repository at this point in the history

  2. Java: Add ZSCAN command (#397) 

    ---------

Co-authored-by: James Duong <[email protected]>
    @GumpacG @jduo
    GumpacG and jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    3fca39e View commit details
    Browse the repository at this point in the history

  3. WIP TODO: support transactions, docs, and more IT

    @GumpacG @jduo
    GumpacG authored and jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    b0d4829 View commit details
    Browse the repository at this point in the history

  4. Added more tests

    @GumpacG @jduo
    GumpacG authored and jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    4c2bf8d View commit details
    Browse the repository at this point in the history

  5. Added tests and javadocs

    @GumpacG @jduo
    GumpacG authored and jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    1124dbd View commit details
    Browse the repository at this point in the history

  6. Improved examples and tests

    @GumpacG @jduo
    GumpacG authored and jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    a6b65d0 View commit details
    Browse the repository at this point in the history

  7. Correct use of SScanOptions instead of ScanOptions for SScan

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    57832c4 View commit details
    Browse the repository at this point in the history

  8. Remove plumbing for SCAN command

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    02891a0 View commit details
    Browse the repository at this point in the history

  9. Sleep after sadd() calls before sscan() calls 

    Due to eventual consistency
    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    b4c0945 View commit details
    Browse the repository at this point in the history

  10. Change sscan cursor to be a String 

    Also fix bug in SharedCommandTests
    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    139a576 View commit details
    Browse the repository at this point in the history

  11. WIP with todos 

    # Conflicts:
#	glide-core/src/protobuf/redis_request.proto
#	glide-core/src/request_type.rs
#	java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
    @GumpacG @jduo
    GumpacG authored and jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    acf074e View commit details
    Browse the repository at this point in the history

  12. Add ZScan to TransactionTestUtilities

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    2af88e4 View commit details
    Browse the repository at this point in the history

  13. Spotless cleanup

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    b775646 View commit details
    Browse the repository at this point in the history

  14. Test fixes

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    a171be5 View commit details
    Browse the repository at this point in the history

  15. Cleanup test code 

    * Apply IntelliJ suggestions
* Use String.valueOf() instead of concatenating empty string
    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    e674dbc View commit details
    Browse the repository at this point in the history

  16. Added better error info for set comparison failures

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    8f73b62 View commit details
    Browse the repository at this point in the history

  17. More logging for test failures

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    cad2fa5 View commit details
    Browse the repository at this point in the history

  18. Add sleeps after zadd() calls 

    To help make sure data is consistent without WAIT
    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    c05ff7c View commit details
    Browse the repository at this point in the history

  19. Longer sleeps

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    a7d270d View commit details
    Browse the repository at this point in the history

  20. Reduce wait time

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    2e607bc View commit details
    Browse the repository at this point in the history

  21. Experiment with unsigned 64-bit cursors

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    397dc6b View commit details
    Browse the repository at this point in the history

  22. Fix rebase error

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    02fed6a View commit details
    Browse the repository at this point in the history

  23. WIP TODO: support transactions, docs, and more IT

    @GumpacG @jduo
    GumpacG authored and jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    dab2b14 View commit details
    Browse the repository at this point in the history

  24. Added more tests

    @GumpacG @jduo
    GumpacG authored and jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    ddd23d4 View commit details
    Browse the repository at this point in the history

  25. Added tests and javadocs

    @GumpacG @jduo
    GumpacG authored and jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    208ff73 View commit details
    Browse the repository at this point in the history

  26. Improved examples and tests

    @GumpacG @jduo
    GumpacG authored and jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    2b34a26 View commit details
    Browse the repository at this point in the history

  27. Apply PR comments 

    * Fix method ordering in BaseTransaction
* Fix broken line breaks within code tags in ScanOptions
* More thoroughly test results in SharedCommandTests
    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    38b9f1a View commit details
    Browse the repository at this point in the history

  28. Add better logging for set comparisons

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    178e89a View commit details
    Browse the repository at this point in the history

  29. Spotless

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    2687823 View commit details
    Browse the repository at this point in the history

  30. Sleep after sadd() calls before sscan() calls 

    Due to eventual consistency
    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    a93405c View commit details
    Browse the repository at this point in the history

  31. Change sscan cursor to be a String 

    Also fix bug in SharedCommandTests
    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    41c4a90 View commit details
    Browse the repository at this point in the history

  32. Update java/integTest/src/test/java/glide/SharedCommandTests.java 

    Co-authored-by: Guian Gumpac <[email protected]>
    @jduo @GumpacG
    jduo and GumpacG committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    5c3c74a View commit details
    Browse the repository at this point in the history

  33. Update java/integTest/src/test/java/glide/SharedCommandTests.java 

    Co-authored-by: Guian Gumpac <[email protected]>
    @jduo @GumpacG
    jduo and GumpacG committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    db453b2 View commit details
    Browse the repository at this point in the history

  34. Fix rebase conflicts

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    de08045 View commit details
    Browse the repository at this point in the history

  35. Fix another rebase conflict

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    863fea9 View commit details
    Browse the repository at this point in the history

  36. Spotless

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    6098957 View commit details
    Browse the repository at this point in the history

  37. Update java/client/src/main/java/glide/api/models/BaseTransaction.java 

    Co-authored-by: Andrew Carbonetto <[email protected]>
    @jduo @acarbonetto
    jduo and acarbonetto authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    f86c903 View commit details
    Browse the repository at this point in the history

  38. Update java/client/src/main/java/glide/api/models/BaseTransaction.java 

    Co-authored-by: Andrew Carbonetto <[email protected]>
    @jduo @acarbonetto
    jduo and acarbonetto authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    bdbc093 View commit details
    Browse the repository at this point in the history

  39. Update java/client/src/main/java/glide/api/models/BaseTransaction.java 

    Co-authored-by: Andrew Carbonetto <[email protected]>
    @jduo @acarbonetto
    jduo and acarbonetto authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    f2b1d11 View commit details
    Browse the repository at this point in the history

  40. Update java/client/src/main/java/glide/api/models/BaseTransaction.java 

    Co-authored-by: Andrew Carbonetto <[email protected]>
    @jduo @acarbonetto
    jduo and acarbonetto authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    f677c60 View commit details
    Browse the repository at this point in the history

  41. Correctly use constants in TransactionTests

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    505c67b View commit details
    Browse the repository at this point in the history

  42. Rename ScanOptions to BaseScanOptions

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    209c4ce View commit details
    Browse the repository at this point in the history

  43. Doc PR fixes

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    5a17ece View commit details
    Browse the repository at this point in the history

  44. Treat end of cursor as failure

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    325e12c View commit details
    Browse the repository at this point in the history

  45. Spotless

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    e441a2c View commit details
    Browse the repository at this point in the history

  46. Fixes

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    cc997bb View commit details
    Browse the repository at this point in the history

  47. Update java/client/src/main/java/glide/api/commands/SortedSetBaseComm… 

    …ands.java

Co-authored-by: Andrew Carbonetto <[email protected]>
    @jduo @acarbonetto
    jduo and acarbonetto authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    8e26687 View commit details
    Browse the repository at this point in the history

  48. Update java/client/src/main/java/glide/api/commands/SortedSetBaseComm… 

    …ands.java

Co-authored-by: Andrew Carbonetto <[email protected]>
    @jduo @acarbonetto
    jduo and acarbonetto authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    089b800 View commit details
    Browse the repository at this point in the history

  49. Update java/client/src/main/java/glide/api/commands/SortedSetBaseComm… 

    …ands.java

Co-authored-by: Andrew Carbonetto <[email protected]>
    @jduo @acarbonetto
    jduo and acarbonetto authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    e89590c View commit details
    Browse the repository at this point in the history

  50. Update java/client/src/main/java/glide/api/commands/SortedSetBaseComm… 

    …ands.java

Co-authored-by: Andrew Carbonetto <[email protected]>
    @jduo @acarbonetto
    jduo and acarbonetto authored Jun 29, 2024
    Configuration menu
    Copy the full SHA
    cfa6cb2 View commit details
    Browse the repository at this point in the history

  51. Minor doc changes

    @jduo
    jduo committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    5c49a5f View commit details
    Browse the repository at this point in the history