Python: add WATCH and UNWATCH commands #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
reviewed
Jun 30, 2024
GumpacG
requested changes
Jul 1, 2024
GumpacG
approved these changes
Jul 1, 2024
Elen-Ghulam
approved these changes
Jul 1, 2024
* Python: add XAUTOCLAIM command * minor doc update * Minor doc update * PR suggestions * Update test assertions with string conversions * PR suggestions * Add clarifying comments
* Added zscan command * Added HSCAN command * Fix tests * Fix tests * Fix tests * Fix tests * Fix tests * Fix tests * Debug tests * Debug tests * Debug tests * Debug tests * Debug tests * Debug tests * Debug tests * Debug tests * Debug tests * Fixed tests and addressed comments * Update python/python/tests/test_async_client.py Co-authored-by: Yury-Fridlyand <[email protected]> --------- Co-authored-by: Yury-Fridlyand <[email protected]>
acarbonetto
approved these changes
Jul 1, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jul 16, 2024
* Python: add WATCH and UNWATCH commands * isort * update redis_client type for test_unwatch_with_route() * add watch to the correct cluster test * add cluster mode note * address comments from GumpacG * Python: added XAUTOCLAIM command (valkey-io#1718) * Python: add XAUTOCLAIM command * minor doc update * Minor doc update * PR suggestions * Update test assertions with string conversions * PR suggestions * Add clarifying comments * Python: Add ZSCAN and HSCAN commands (valkey-io#1732) * Added zscan command * Added HSCAN command * Fix tests * Fix tests * Fix tests * Fix tests * Fix tests * Fix tests * Debug tests * Debug tests * Debug tests * Debug tests * Debug tests * Debug tests * Debug tests * Debug tests * Debug tests * Fixed tests and addressed comments * Update python/python/tests/test_async_client.py Co-authored-by: Yury-Fridlyand <[email protected]> --------- Co-authored-by: Yury-Fridlyand <[email protected]> * Python: add WATCH and UNWATCH commands * Python: add WATCH and UNWATCH commands * add changelog * fix broken syntax after solving conflicts --------- Co-authored-by: Aaron <[email protected]> Co-authored-by: Guian Gumpac <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Add WATCH and UNWATCH commands
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.