Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Add ZINCRBY command #2009

Merged

Conversation

acarbonetto
Copy link
Collaborator

No description provided.

@acarbonetto acarbonetto self-assigned this Jul 24, 2024
@acarbonetto acarbonetto requested a review from a team as a code owner July 24, 2024 16:27
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transaction impl + test are missing. Linter check fails too.

CHANGELOG.md Outdated Show resolved Hide resolved
node/src/BaseClient.ts Show resolved Hide resolved
* @param key - The key of the sorted set.
* @param increment - The score increment.
* @param member - A member of the sorted set.
*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*

node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Show resolved Hide resolved
python/python/glide/async_commands/core.py Show resolved Hide resolved
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto force-pushed the node/integ_acarbo_add_zincrby_valkey-33 branch from 025e08c to e5715d6 Compare July 25, 2024 21:46
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto merged commit b778d35 into valkey-io:main Jul 25, 2024
13 checks passed
@acarbonetto acarbonetto deleted the node/integ_acarbo_add_zincrby_valkey-33 branch July 25, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants