Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Add ZRANGESTORE command #2068

Merged
merged 12 commits into from
Aug 9, 2024

Conversation

acarbonetto
Copy link
Collaborator

Adds the ZRANGESTORE command to node.js client.

@acarbonetto acarbonetto self-assigned this Aug 1, 2024
@acarbonetto acarbonetto requested a review from a team as a code owner August 1, 2024 07:07
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto force-pushed the node/integ_acarbo_zrangestore branch from 533af1b to 95e5a0d Compare August 7, 2024 22:47
node/tests/GlideClusterClient.test.ts Outdated Show resolved Hide resolved
node/tests/TestUtilities.ts Outdated Show resolved Hide resolved
Signed-off-by: Andrew Carbonetto <[email protected]>
* const result = await client.zrangeStore("destination_key", "my_sorted_set", { start: 0, stop: -1 });
* console.log(result); // Output: 7 - "destination_key" contains a sorted set with the 7 members from "my_sorted_set".
* ```
* @example
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we create a single @example or two?

Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add version check for all tests.
If possible, please also add comments to the tests to help reader understand each step.

Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto merged commit c101a6d into valkey-io:main Aug 9, 2024
8 checks passed
@acarbonetto acarbonetto deleted the node/integ_acarbo_zrangestore branch August 9, 2024 16:50
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Aug 12, 2024
* Node: Add ZRANGESTORE command

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants