Node: Add GEOSEARCHSTORE command.
#2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
yipin-chen
approved these changes
Aug 2, 2024
GumpacG
approved these changes
Aug 2, 2024
| if (resultOptions.withCoord) args.push("WITHCOORD"); | ||
| if (resultOptions.withDist) args.push("WITHDIST"); | ||
| if (resultOptions.withHash) args.push("WITHHASH"); | ||
| if ("withCoord" in resultOptions && resultOptions.withCoord) |
There was a problem hiding this comment.
Is the first check needed? Would it be false even if it doesn't exist?
There was a problem hiding this comment.
First check is needed to confirm that I can access to with*. I have to update this code, because there are 2 derived types with different sets of fields.
…9-geosearchstore Signed-off-by: Yury-Fridlyand <[email protected]>
acarbonetto
approved these changes
Aug 7, 2024
GumpacG
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Aug 7, 2024
* Add `GEOSEARCHSTORE` command. Signed-off-by: Yury-Fridlyand <[email protected]> * Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]>
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Aug 12, 2024
* Add `GEOSEARCHSTORE` command. Signed-off-by: Yury-Fridlyand <[email protected]> * Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Chloe Yip <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.