Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Add command GETEX #2107

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

tjzhang-BQ
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ commented Aug 8, 2024

adding command GETEX & updating command Set's optional input SetOptions to use the newly added enum TimeUnit. Add transaction test for Set with options that was missing.

node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Show resolved Hide resolved
node/tests/TestUtilities.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Show resolved Hide resolved
node/src/Commands.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Show resolved Hide resolved
node/src/BaseClient.ts Show resolved Hide resolved
node/src/Transaction.ts Show resolved Hide resolved
@tjzhang-BQ tjzhang-BQ force-pushed the node/integ_tjz_VALKEY-21-getex branch from ca8f787 to ac00647 Compare August 9, 2024 19:10
@yipin-chen
Copy link
Collaborator

Need to address CI errors.

node/src/Commands.ts Outdated Show resolved Hide resolved
node/src/Commands.ts Outdated Show resolved Hide resolved
node/src/Commands.ts Outdated Show resolved Hide resolved
Signed-off-by: TJ Zhang <[email protected]>
@tjzhang-BQ tjzhang-BQ force-pushed the node/integ_tjz_VALKEY-21-getex branch from 1def830 to 6a30b6b Compare August 13, 2024 06:43
Signed-off-by: TJ Zhang <[email protected]>
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Commands.ts Outdated Show resolved Hide resolved
TJ Zhang added 3 commits August 13, 2024 16:16
Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: TJ Zhang <[email protected]>
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

node/tests/TestUtilities.ts Show resolved Hide resolved
@tjzhang-BQ tjzhang-BQ merged commit 27342ab into valkey-io:main Aug 14, 2024
8 checks passed
@tjzhang-BQ tjzhang-BQ deleted the node/integ_tjz_VALKEY-21-getex branch August 14, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants