Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: add binary support to string commands #2183

Merged

Conversation

tjzhang-BQ
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ commented Aug 21, 2024

commands included:

  • SET
  • INCR
  • INCRBY
  • INCRBYFLOAT
  • DECR
  • DECRBY
  • GETEX
  • LCS

@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner August 21, 2024 22:44
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleas add tests

CHANGELOG.md Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Show resolved Hide resolved
@tjzhang-BQ tjzhang-BQ force-pushed the node/integ-tjz-VALKEY-262-string-commands branch from 912e93c to 0dd3905 Compare August 22, 2024 02:58
CHANGELOG.md Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
@tjzhang-BQ tjzhang-BQ force-pushed the node/integ-tjz-VALKEY-262-string-commands branch 2 times, most recently from 68cc91f to ca8bbb7 Compare August 22, 2024 22:43
node/src/BaseClient.ts Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Show resolved Hide resolved
@tjzhang-BQ tjzhang-BQ force-pushed the node/integ-tjz-VALKEY-262-string-commands branch from 2877fd7 to 72e6741 Compare August 26, 2024 18:31
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
Signed-off-by: TJ Zhang <[email protected]>
@tjzhang-BQ tjzhang-BQ force-pushed the node/integ-tjz-VALKEY-262-string-commands branch from 07d59b1 to a9fd133 Compare August 28, 2024 18:24
@tjzhang-BQ tjzhang-BQ merged commit 015d5a9 into valkey-io:main Aug 28, 2024
9 checks passed
@tjzhang-BQ tjzhang-BQ deleted the node/integ-tjz-VALKEY-262-string-commands branch August 28, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants