Java: Fix byte GlideString conversion to String bug #2271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug that incorrectly converts non UTF-8 bytes GlideString to String with the value
"Value not convertible to string: byte[] "
instead of throwing an exception.Affected APIs:
convertMapToKeyValueGlideStringArray:
public CompletableFuture<String> msetBinary(@NonNull Map<GlideString, GlideString> keyValueMap)
public CompletableFuture<Long> hset( @NonNull GlideString key, @NonNull Map<GlideString, GlideString> fieldValueMap)
public CompletableFuture<GlideString> xadd( @NonNull GlideString key, @NonNull Map<GlideString, GlideString> values, @NonNull StreamAddOptionsBinary options)
public CompletableFuture<Boolean> msetnxBinary( @NonNull Map<GlideString, GlideString> keyValueMap)
convertNestedArrayToKeyValueGlideStringArray:
public CompletableFuture<GlideString> xadd( @NonNull GlideString key, @NonNull GlideString[][] values, @NonNull StreamAddOptionsBinary options)
convertMapToValueKeyStringArrayBinary:
public CompletableFuture<Long> zadd( @NonNull GlideString key, @NonNull Map<GlideString, Double> membersScoresMap, @NonNull ZAddOptions options, boolean changed)
Reproduction steps for the bug:
Run
See the output to be
Value not convertible to string: byte[] 13
Expected
We expect an exception to be thrown in order to avoid unintended data to be stored in the server.