Java: Create Workflow to deploy artifacts for all platforms mentioned in build.matrix.json #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
cyip10
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
cyip10
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
cyip10
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
GumpacG
previously requested changes
Sep 12, 2024
There was a problem hiding this comment.
You can revert files irrelevant to your changes by getting the file from main using https://www.freecodecamp.org/news/git-checkout-file-from-another-branch/
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
.github/workflows/java-cd.yml
Outdated
|
|
||
| runs-on: ${{ matrix.host.RUNNER }} | ||
| steps: | ||
| - name: Start Redis server |
There was a problem hiding this comment.
Why redis, not valkey? Why you don't reuse install-valkey action?
There was a problem hiding this comment.
i think it was because the procedure to install redis is easier than valkey. i can try out install-valkey
There was a problem hiding this comment.
Is it really that different? Valkey is just a fork of Redis.
There was a problem hiding this comment.
actually, valkey doesn't have an installer package and you need to install from source.
but the install-valkey workflow is available to do that for us.
Signed-off-by: Chloe Yip <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
acarbonetto
approved these changes
Sep 13, 2024
| @@ -12,7 +13,7 @@ dependencies { | |||
| def releaseVersion = System.getenv("GLIDE_RELEASE_VERSION"); | |||
|
|
|||
| if (releaseVersion) { | |||
| implementation "io.valkey:valkey-glide:" + releaseVersion | |||
| implementation "io.valkey:valkey-glide:" + releaseVersion + ":${osdetector.classifier}" | |||
| test-deployment-on-all-architectures: | ||
| needs: [set-release-version, load-platform-matrix, publish-to-maven-central-deployment] | ||
| env: | ||
| JAVA_VERSION: "11" |
There was a problem hiding this comment.
ok - fine. good enough.
Yury-Fridlyand
approved these changes
Sep 13, 2024
Yury-Fridlyand
dismissed
GumpacG’s stale review
All comments were addressed
cyip10
changed the title
acarbonetto
reviewed
Sep 13, 2024
cyip10
changed the title
Signed-off-by: Chloe Yip <[email protected]>
acarbonetto
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Sep 18, 2024
… in build.matrix.json (valkey-io#2285) Signed-off-by: Chloe Yip <[email protected]>
acarbonetto
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Sep 19, 2024
… in build.matrix.json (valkey-io#2285) Signed-off-by: Chloe Yip <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
Testing against 1.0.2-rc1