-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(earn): support partial withdrawals #6128
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6128 +/- ##
==========================================
- Coverage 88.75% 88.71% -0.05%
==========================================
Files 727 727
Lines 30752 30825 +73
Branches 5317 5646 +329
==========================================
+ Hits 27295 27346 +51
+ Misses 3414 3281 -133
- Partials 43 198 +155
... and 65 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
# Conflicts: # src/earn/EarnDepositBottomSheet.tsx
Co-authored-by: Finnian Jacobson-Schulte <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run through deposit, and swap-deposit flows again to ensure they still work? Also making sure that they are correct for stable and non stable coins
src/earn/EarnEnterAmount.tsx
Outdated
isWithdrawal ? inputToken.tokenId : withdrawToken.tokenId | ||
) | ||
const localToToken = useLocalToTokenAmount( | ||
parsedLocalAmount, | ||
isWithdrawal ? inputToken.tokenId : withdrawToken.tokenId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 96caa2e!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the withdrawToken state can be removed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Adds the ability to support partial withdrawals from Earn pools and adds the feature gate
allow_earn_partial_withdrawal
to enable this feature.Test plan
Related issues
Backwards compatibility
Yes
Network scalability
Yes