Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show back cover #1030

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

stubb
Copy link
Contributor

@stubb stubb commented May 10, 2020

This pull request adds the ability to show the back cover of an album. I added this feature to be able to read the descriptions of audio books and audio dramas. It helps me to distinguish single episodes.

Thats how it looks:
grafik

I added a onClick Handler for each entry of mediatype 'Album'. The click event is filtered within the LibraryPagerAdapter and requests the backcover from the CoverCache. The cover will be displayed within a popup. This can be dismissed with a click on itself or a click on the background.

Feel free to suggest some changes!

Note: I did not merge the master branch of vanilla-music/vanilla repo into the PR branch yet, since there are currently no conflicts.

Kilian Köppchen added 5 commits May 10, 2020 14:54
Opens a popup during click on tiny cover within library.
The popup shows the back cover and can be dismissed by a click on itself
or the background.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant