Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt swift-format #198

Merged
merged 8 commits into from
Oct 3, 2024
Merged

Adopt swift-format #198

merged 8 commits into from
Oct 3, 2024

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Sep 23, 2024

No description provided.

@ptoffy ptoffy requested a review from gwynne as a code owner September 23, 2024 17:06
@ptoffy ptoffy changed the title Adopt SwiftFormat Adopt swift-format Sep 23, 2024
@ptoffy ptoffy linked an issue Sep 23, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 90.94828% with 21 lines in your changes missing coverage. Please review.

Project coverage is 77.29%. Comparing base (5c073a0) to head (e2818b6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/JWTKit/JWK/JWK.swift 33.33% 4 Missing ⚠️
Sources/JWTKit/JWTHeaderField.swift 92.72% 4 Missing ⚠️
Sources/JWTKit/RSA/JWTKeyCollection+RSA.swift 87.50% 4 Missing ⚠️
Sources/JWTKit/JWTKeyCollection.swift 82.35% 3 Missing ⚠️
Sources/JWTKit/HMAC/HMACSigner.swift 83.33% 2 Missing ⚠️
Sources/JWTKit/JWK/JWKSigner.swift 92.00% 2 Missing ⚠️
Sources/JWTKit/HMAC/JWTKeyCollection+HMAC.swift 88.88% 1 Missing ⚠️
Sources/JWTKit/X5C/X5CVerifier.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
+ Coverage   76.82%   77.29%   +0.47%     
==========================================
  Files          55       55              
  Lines        1290     1352      +62     
==========================================
+ Hits          991     1045      +54     
- Misses        299      307       +8     
Files with missing lines Coverage Δ
Sources/JWTKit/Claims/JWTClaim.swift 100.00% <100.00%> (ø)
Sources/JWTKit/Claims/JWTMultiValueClaim.swift 65.30% <100.00%> (+0.72%) ⬆️
Sources/JWTKit/Claims/JWTUnixEpochClaim.swift 100.00% <100.00%> (ø)
Sources/JWTKit/Claims/LocaleClaim.swift 100.00% <ø> (ø)
Sources/JWTKit/ECDSA/ECDSA.swift 86.79% <ø> (ø)
Sources/JWTKit/ECDSA/ECDSASigner.swift 90.47% <ø> (-0.44%) ⬇️
Sources/JWTKit/ECDSA/JWTKeyCollection+ECDSA.swift 100.00% <100.00%> (ø)
Sources/JWTKit/ECDSA/P256+CurveType.swift 100.00% <ø> (ø)
Sources/JWTKit/ECDSA/P384+CurveType.swift 100.00% <ø> (ø)
Sources/JWTKit/ECDSA/P521+CurveType.swift 100.00% <ø> (ø)
... and 23 more

@ptoffy ptoffy requested a review from 0xTim October 3, 2024 14:15
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall nice to be consistent

I think we can make the line length longer. And there are some Swift 6 checks that should have been removed

One thing to check - can we run this as a plugin or is that not a thing yet?

.swift-format Outdated Show resolved Hide resolved
Sources/JWTKit/ECDSA/P256+CurveType.swift Outdated Show resolved Hide resolved
Sources/JWTKit/ECDSA/P384+CurveType.swift Outdated Show resolved Hide resolved
Sources/JWTKit/ECDSA/P521+CurveType.swift Outdated Show resolved Hide resolved
Sources/JWTKit/EdDSA/EdDSA.swift Outdated Show resolved Hide resolved
@ptoffy ptoffy requested a review from 0xTim October 3, 2024 15:32
@ptoffy ptoffy merged commit 708901e into main Oct 3, 2024
11 checks passed
@ptoffy ptoffy deleted the swift-format branch October 3, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt Swift Format
2 participants