Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shields from the room list #4115

Closed
manuroe opened this issue Mar 12, 2021 · 0 comments · Fixed by #4127
Closed

Remove shields from the room list #4115

manuroe opened this issue Mar 12, 2021 · 0 comments · Fixed by #4127
Assignees
@manuroe
Labels
performance
Milestone
Sprint - Element ...

Comments

@manuroe
Copy link
Member

manuroe commented Mar 12, 2021

From element-android created by bmarty: element-hq/element-android#2991

Remove shields from the room list.

It should allow to greatly improve the performance, especially after login to a big account with lots of e2e rooms, because computing the room shield require to load all the room members and their device, download their keys, etc.

Shields will stay visible when in the room detail screen (timeline), and on all its sub-screens.

EW does not display shield on the room list as well.
@manuroe manuroe mentioned this issue Mar 12, 2021
Closed
@manuroe manuroe added this to the Sprint - Element 1.2.7 milestone Mar 12, 2021
@manuroe manuroe self-assigned this Mar 15, 2021
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Mar 17, 2021
@manuroe
MXRoomSummary: Add enableTrustTracking() to compute and maintain trus…
d38153e 
…t value for the given room

element-hq/element-ios/issues/4115
manuroe added a commit that referenced this issue Mar 17, 2021
@manuroe
Room lists: Remove shields on room avatars
31be085 
#4115

but keep it in the room screen
This was referenced Mar 17, 2021
Merged
Merged
manuroe added a commit that referenced this issue Mar 17, 2021
@manuroe
Room lists: Remove shields on room avatars
b88d152 
#4115

but keep it in the room screen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
performance
Projects
None yet
Milestone
Sprint - Element 1.2.7
Development

Successfully merging a pull request may close this issue.

Room lists: Remove shields on room avatars element-hq/element-ios
1 participant
@manuroe