Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove permission popups on a new sign in/up #4484

Closed
1 of 2 tasks
manuroe opened this issue Jun 28, 2021 · 10 comments
Closed
1 of 2 tasks

Remove permission popups on a new sign in/up #4484

manuroe opened this issue Jun 28, 2021 · 10 comments
Assignees
Labels
feature:privacy X-Needs-Design May require input from the design team Z-D1 Issues that can impact the Day-2 retention Z-Impact-1 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-1

Comments

@manuroe
Copy link
Member

manuroe commented Jun 28, 2021

We currently display 2 permission popups after logging in on a fresh app install:

  • Contact access. We should ask it only if the users go to the people tab. This is a regression
  • Logs gathering. We should ask later after several uses. We need to check what element-android does.

This is too much for a new user. We should remove them.

@manuroe manuroe added feature:privacy Z-Papercuts Visible. Impactful. Predictable to action. labels Jun 28, 2021
@manuroe manuroe added this to the iOS platform papercuts milestone Jun 28, 2021
@pixlwave
Copy link
Member

  • Contact access. We should ask it only if the users go to the people tab. This is a regression

Testing with both develop and 1.4.3 from the App Store, I only seeing this pop-up when tapping the people tab? 😕

@pixlwave
Copy link
Member

Logs gathering. We should ask later after several uses. We need to check what element-android does.

Android asks to send a crash log only after a crash occurred and doesn't yet have analytics, so there's no comparable prompt to match the behaviour to.

@manuroe manuroe added Z-Impact-1 Z-Visibility-1 X-Needs-Design May require input from the design team labels Jul 2, 2021
@pixlwave
Copy link
Member

pixlwave commented Jul 7, 2021

It's worth noting as this may affect the choice around when to prompt for gathering logs:

  • If the user didn't verify their session on sign in, they will be presented with a prompt to verify on the second launch if it's a fresh install.

@niquewoodhouse
Copy link

Just want to set expectations, I think this might be a larger design challenge than a quick papercut, and it might take a bit of time to identify the right place to ask for contact access, and the right way to ask (copy + design).

Especially if we're not able to test performance of the permissions. I'm very happy to work on this but it might be mid next week before we have some proposals to discuss around.

@pixlwave
Copy link
Member

pixlwave commented Jul 9, 2021

Sure, makes sense. Thanks for letting me know 👍

@ShadowJonathan
Copy link
Contributor

I'd argue that it should pop up after a user has scrolled down in the People tab and saw "find people from contacts", and then press that banner.
Maybe a "you'll be asked for contacts permissions, this data will be checked against a server owned by Element, do you want to continue Y/N?" after the banner but before the prompt would also help explain to users what's going on.

@niquewoodhouse
Copy link

  • Logs gathering. We should ask later after several uses. We need to check what element-android does.

How are the logs currently used @manuroe + what's the aim with them? I'm wondering if moving them until after several uses means we'll lose the ability to spot issues that impact early retention because we'll not have that information anymore (only people who've returned several times will actually see this)

@manuroe manuroe added the Z-D1 Issues that can impact the Day-2 retention label Oct 12, 2021
@niquewoodhouse
Copy link

@pixlwave I see there are other issues around this area like element-hq/element-meta#41 so I think I'll leave this one. I put some very early WIP here if it helps anyone working on that in the future

@daniellekirkwood daniellekirkwood self-assigned this Nov 15, 2021
@daniellekirkwood
Copy link
Contributor

@manuroe as we've redesigned the whole new flow and taken the pop-ups into consideration as we do, are you happy for us to close this issue and create new ones if we have new data based on the update that will land soon?

@manuroe
Copy link
Member Author

manuroe commented Jul 20, 2022

yes, sure.

@manuroe manuroe closed this as completed Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:privacy X-Needs-Design May require input from the design team Z-D1 Issues that can impact the Day-2 retention Z-Impact-1 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-1
Projects
None yet
Development

No branches or pull requests

6 participants