Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Message" is the fallback notification for too many things #4653

Closed
3 tasks
Tracked by #4132
pixlwave opened this issue Aug 3, 2021 · 2 comments · Fixed by #4662
Closed
3 tasks
Tracked by #4132

"Message" is the fallback notification for too many things #4653

pixlwave opened this issue Aug 3, 2021 · 2 comments · Fixed by #4662
Assignees
@pixlwave
Labels
Z-Impact-1 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-1
Milestone
iOS platform pape...

Comments

@pixlwave
Copy link
Member

pixlwave commented Aug 3, 2021 •
edited
Loading

Some are described below

  • Unhandled event types e.g. Reactions
  • Unhandled message msgtypes e.g. Notice events
  • Errors: unable to fetch or decrypt, No active account found
@pixlwave pixlwave mentioned this issue Aug 3, 2021
Open
18 tasks
@pixlwave pixlwave self-assigned this Aug 3, 2021
@pixlwave pixlwave changed the title "Message" is the fallback notification for too many things. Some are described below "Message" is the fallback notification for too many things Aug 3, 2021
@pixlwave
Copy link
Member Author

pixlwave commented Aug 3, 2021 •
edited
Loading

It would make sense to generalise "Message" more as it is a fallback for all sorts of events. "Notification" seems the most obvious as it would match iOS's default notification text when previews are disabled, and could apply to any type of event.

@pixlwave
Copy link
Member Author

pixlwave commented Aug 3, 2021 •
edited
Loading

An example of what this would look like with the room's title included:

Screenshot 2021-08-03 at 17 13 57

@pixlwave pixlwave added Z-Impact-2 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-1 labels Aug 4, 2021
@pixlwave pixlwave added this to the iOS platform papercuts milestone Aug 4, 2021
@pixlwave pixlwave mentioned this issue Aug 4, 2021
Merged
@pixlwave pixlwave linked a pull request Aug 4, 2021 that will close this issue
Improve notification content #4662
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixlwave pixlwave

Labels
Z-Impact-1 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-1
Projects
None yet
Milestone
iOS platform papercuts (moved to http...
Development

Successfully merging a pull request may close this issue.

Improve notification content element-hq/element-ios
1 participant
@pixlwave