Clear easy Xcode warnings in Modules

[langleyd]

What this issue is for

• This is a Long list of modules to give us a focus point in order to progress through warnings within element-iOS. Hopefully if we clear the easy issues within these modules we are just eft with a shortlist which is more actionable. If we find this useful, we can expand it to the rest of the project and other projects.

Tips

• If you are making large changes to a module, why not clear the warnings while you are at it and tick off the box!
• Link this issue to PR's that tackle warnings within part of the project.
• Use this issue to share thoughts on challenges encountered.
• Not every subfolder has been included/expanded yet. Feel free to add more.
• If we complete all items in a subfolder we can probably remove the expanded items and just tick the top item.

Modules with Warnings

• Application
• Authentication
• BadgeLabel
• BugReport
• Call
• CallTransfer
• Camera
• Common
  • ActivityIndicator
  • Alert
  • Avatar
  • Cells
  • CollectionView
  • KeywordAvoiding
  • Models
  • NavigationController
  • Presentation
  • Recents
  • SectionHeaders
  • SegmentedViewController
  • TableView
  • Views
  • WebViewController
• Communities
• Contacts
• CreateRoom
• CrossSigning
• DeepLink
• DotsView
• EncryptionInfo
• Favorites
• GDPR
• GlobalSearch
• Home
• Integrations
• KeyBackup
• KeyVerifications
• LaunchLoading
• MajorUpdate
• MediaPicker
• People
• PublicRoomList
• QRCode
• Reautentication
• Room
  • Attachments
  • BubbleReactions
  • CellData
  • ContextualMenu
  • CreationModal
  • DataSources
  • EditHistory
  • EmojiPicker
  • Files
  • Members
  • NotificaitonSettings
  • ReactionHistory
  • ReadReceiptsDetail
  • RoomInfo
  • Search
  • Settings
  • Views
  • VoiceMessages
• RoomKeyRequest
• Rooms
• Secrets
• SecureBackup
• ServiceTerms
• SetPinCode
• Settings
• SideMenu
• SlidingModal
• Spaces
• SplitView
• StartChat
• TabBar
• User
• UserDevices
• UserInteractiveAuthentication