Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When accepting an invite, expecting to see the room (iOS) #4986

Closed
giomfo opened this issue Oct 12, 2021 · 5 comments · Fixed by #6035
Closed

When accepting an invite, expecting to see the room (iOS) #4986

giomfo opened this issue Oct 12, 2021 · 5 comments · Fixed by #6035
Labels
A-DMs T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-D1 Issues that can impact the Day-2 retention Z-Papercuts Visible. Impactful. Predictable to action. Z-WTF WTF issues: High impact, Low Effort

Comments

@giomfo
Copy link
Member

giomfo commented Oct 12, 2021

Your use case

User feedback: "When I accept an invitation to a room, after the invite is processed I would expect to see the room. Instead it is hidden somewhere in my room list, forcing me to use search to find it, to find out if there are any messages there for me to react to."

See the original discussion in Element-Android: element-hq/element-android#3771

I agree with the 2 following comments in this Element-Android issue:
image

Have you considered any alternatives?

No response

Additional context

No response
@giomfo giomfo added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Papercuts Visible. Impactful. Predictable to action. labels Oct 12, 2021
@manuroe manuroe added the Z-D1 Issues that can impact the Day-2 retention label Oct 12, 2021
@daniellekirkwood daniellekirkwood added X-Needs-Product Requires input from the product team X-Needs-Design May require input from the design team and removed X-Needs-Product Requires input from the product team labels Oct 18, 2021
@giomfo giomfo mentioned this issue Nov 16, 2021
Closed
@daniellekirkwood daniellekirkwood added A-DMs Z-WTF WTF issues: High impact, Low Effort labels Jan 11, 2022
@daniellekirkwood daniellekirkwood removed the X-Needs-Design May require input from the design team label Jan 24, 2022
@daniellekirkwood daniellekirkwood self-assigned this Jan 24, 2022
@daniellekirkwood daniellekirkwood changed the title When accepting an invite, expecting to see the room When accepting an invite, expecting to see the room (iOS) Feb 10, 2022
@daniellekirkwood
Copy link
Contributor

I believe this flow has been redesigned by @gaelledel and therefore the Product and Design questions have been answered.

@gaelledel Could you link the figma flow so that we can mark this issue as "ready"? Thanks!

@daniellekirkwood daniellekirkwood removed the X-Needs-Product Requires input from the product team label Feb 22, 2022
@gaelledel
Copy link

yep, here it is: https://www.figma.com/file/OvsSONqAyabcUDYp8tnEs6/Start-a-Chat?node-id=68%3A31998

@daniellekirkwood
Copy link
Contributor

Thank you!

@giomfo
Copy link
Member Author

giomfo commented Feb 25, 2022

@daniellekirkwood FYI the plan here is to apply the same change in Element-iOS as the one already merged in Element-Android here
This change concerns only the flow
I will assign it to @yostyle who will be in charge of it for Element-ios

Note: the attached design suggests improvements about the invite preview. Another issue should be created to plan it.
Let's sync about together eventually

@giomfo giomfo assigned yostyle and unassigned gaelledel Feb 25, 2022
@giomfo
Copy link
Member Author

giomfo commented Mar 11, 2022

@yostyle is not available to work on it for the moment. I remove the assignment to let it takeable

@yostyle yostyle mentioned this issue Apr 13, 2022
Merged
@giomfo giomfo mentioned this issue Apr 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-DMs T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-D1 Issues that can impact the Day-2 retention Z-Papercuts Visible. Impactful. Predictable to action. Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

When accepting an invite, expecting to see the room element-hq/element-ios
5 participants
@yostyle @manuroe @giomfo @gaelledel @daniellekirkwood