Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remeber keyboard language for room #5067

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Remeber keyboard language for room #5067

merged 1 commit into from
Nov 5, 2021

Conversation

kloenk
Copy link
Contributor

@kloenk kloenk commented Oct 31, 2021 •
edited
Loading

This adds a textInputContextIdentifier to the RoomViewController to save the current language per room.

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@kloenk
Remember keyboard language for room
f284f2f 
This adds a `textInputContextIdentifier` to the RoomViewController to save the current language per room.

Signed-off-by: Finn Behrens <[email protected]>
pixlwave
pixlwave approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution @kloenk, this is a great addition to the app.

@pixlwave pixlwave merged commit 4017817 into element-hq:develop Nov 5, 2021
@kloenk kloenk deleted the keyboard_context branch November 5, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kloenk @pixlwave