Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The DisabledRoomInputToolbarView isn't shown when you don't have permissions to post #5079

Closed
pixlwave opened this issue Nov 2, 2021 · 0 comments · Fixed by #5087
Closed

The DisabledRoomInputToolbarView isn't shown when you don't have permissions to post #5079

pixlwave opened this issue Nov 2, 2021 · 0 comments · Fixed by #5087
Assignees
@pixlwave
Labels
A-Composer O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@pixlwave
Copy link
Member

pixlwave commented Nov 2, 2021 •
edited
Loading

Steps to reproduce

  1. Enter a room where you don't have a sufficient power-level to post such as #homeowners:matrix.org

What did you expect to happen?

To see a disabled composer instead of the text view.

What happened?

The app allows me to attempt to send a message which results in a "messages failed to send" error.

Explanation

RoomViewController's updateRoomInputToolbarViewClassIfNeeded is called before the room's data source has been set, so whether or not the user can post is unknown.

Your phone model

iPhone 12

Operating system version

iOS 15.1

Application version

Element 1.6.7 develop
@pixlwave pixlwave added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Nov 2, 2021
@pixlwave pixlwave added A-Composer O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Nov 2, 2021
@pixlwave pixlwave self-assigned this Nov 2, 2021
@pixlwave pixlwave mentioned this issue Nov 3, 2021
Merged
@pixlwave pixlwave linked a pull request Nov 3, 2021 that will close this issue
Fix DisabledRoomInputToolbarView / Room Previews / Favourites #5087
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixlwave pixlwave

Labels
A-Composer O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix DisabledRoomInputToolbarView / Room Previews / Favourites element-hq/element-ios
2 participants
@ismailgulek @pixlwave