Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reply rendering bug for displaynames containing "<" #5526

Closed
noantiq opened this issue Feb 9, 2022 · 1 comment · Fixed by #6266
Closed

Reply rendering bug for displaynames containing "<" #5526

noantiq opened this issue Feb 9, 2022 · 1 comment · Fixed by #6266
Assignees
@aringenbach
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Papercuts Visible. Impactful. Predictable to action. Z-WTF WTF issues: High impact, Low Effort

Comments

@noantiq
Copy link
Contributor

noantiq commented Feb 9, 2022

Steps to reproduce

  1. Set your roomnick to a username containing "<"
  2. Send a message in the room
  3. Get a reply to that message

Outcome

What did you expect?

Reply is rendered correctly

What happened instead?

  • the username is cut off beginning with the "<"
  • The whole original message is displayed in green
  • You can click on the cited original message and get to the users "profile" as if you clicked on their username

9578F269-2810-4F61-9192-186C75622FAF

Your phone model

iPhone8

Operating system version

iOS 15.3

Application version

Element 1.7.0

Homeserver

No response

Will you send logs?

No
@noantiq noantiq added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Feb 9, 2022
@pixlwave pixlwave changed the title Reply rendering bug for usernames containing "<" Reply rendering bug for displaynames containing "<" Feb 9, 2022
@pixlwave pixlwave added A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Feb 9, 2022
@pixlwave
Copy link
Member

Potentially related to #4586 in that reply parsing needs to be made more robust.

@pixlwave pixlwave added Z-Papercuts Visible. Impactful. Predictable to action. Z-WTF WTF issues: High impact, Low Effort labels Feb 18, 2022
@aringenbach aringenbach self-assigned this Jun 10, 2022
@aringenbach aringenbach mentioned this issue Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aringenbach aringenbach

Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Papercuts Visible. Impactful. Predictable to action. Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix reply to usernames containing HTML escape characters element-hq/element-ios
3 participants
@pixlwave @noantiq @aringenbach