Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to open a sub space #5965

Closed
noantiq opened this issue Apr 4, 2022 · 6 comments · Fixed by #6080
Closed

Fail to open a sub space #5965

noantiq opened this issue Apr 4, 2022 · 6 comments · Fixed by #6080
Assignees
Labels
A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@noantiq
Copy link
Contributor

noantiq commented Apr 4, 2022

Steps to reproduce

  1. Have a public space with another public space as a child.
  2. Copy the space alias for the child space
  3. Send the space alias to a room
  4. Click on the space alias (rendered as a link)
  5. Click on open when getting prompted to open that space for that you just clicked the alias.

Outcome

What did you expect?

I get taken to the space I wanted to open.

What happened instead?

I get taken to the Home tab of whichever space I was in at the moment.

Your phone model

No response

Operating system version

No response

Application version

1.8.10

Homeserver

No response

Will you send logs?

No

@noantiq noantiq added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Apr 4, 2022
@stefanceriu stefanceriu added A-Spaces Spaces, groups, communities S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Apr 6, 2022
@gileluard gileluard added the X-Needs-Design May require input from the design team label Apr 6, 2022
@gileluard
Copy link
Contributor

@kittykat @amshakal @niquewoodhouse

If the user taps open button from the preview bottom sheet, the space switching is processed by the side menu in order to update the current selection. This works well for root spaces but cannot work for subspaces as subspaces are not displayed in the side menu and no space can be selected. I can make the space switching work but nothing will be selected in the side menu.

@kittykat
Copy link
Contributor

kittykat commented Apr 7, 2022

Here are the designs we already have:

image

@gileluard
Copy link
Contributor

Sure. We could make a feature request for it.

On the other hand, if the user selects a space you can see all the the rooms of the subspaces in the home tab. As a fix for this issue, we could select the first root space which is an ancestor of the linked space.

@niquewoodhouse
Copy link

Sure. We could make a feature request for it.

I think we should be a bit cautious about doing much here for now. If other projects that might be happening soon work, then the way of navigating spaces might chance a lot, so I'd be concerned about putting a lot of time into this.

@gileluard have you got some suggested fixes?

@gileluard
Copy link
Contributor

@niquewoodhouse

Here are my to possible fixes:

@niquewoodhouse
Copy link

@gileluard thanks for taking me through your solutions. As we discussed, I think this would make the most sense for now:

  • Show the root space as selected in the sidebar
  • Change the text in the header to reflect the root space + subspace relationship1

1 I thought this could work: show root space name / subspace name. If its a sub subspace, show the same, root / subspace only, no need to show middle spaces. Are we able to know if the names are too long? If so, reducing the root space with a ... would be nicer than reducing the subspace name, I think (left image below).

image

@niquewoodhouse niquewoodhouse removed the X-Needs-Design May require input from the design team label Apr 22, 2022
@niquewoodhouse niquewoodhouse removed their assignment Apr 22, 2022
gileluard added a commit that referenced this issue Apr 27, 2022
gileluard added a commit that referenced this issue Apr 28, 2022
- Update after review
gileluard added a commit that referenced this issue May 3, 2022
* Fail to open a sub space #5965

- Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants