Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID server access token not included when making a 3pid invite #6385

Closed
richvdh opened this issue Jul 6, 2022 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#1518
Closed

ID server access token not included when making a 3pid invite #6385

richvdh opened this issue Jul 6, 2022 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#1518
Assignees
@pixlwave
Labels
A-Create-Room A-Invite T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@richvdh
Copy link
Member

richvdh commented Jul 6, 2022

Steps to reproduce

Send an invite to a third-party id (eg an email address or phone number)

Outcome

What did you expect?

id_access_token param should be included, since the spec requires it

What happened instead?

No id_access_token parameter

Your phone model

No response

Operating system version

iOS 15.5

Application version

Riot/1.8.19

Homeserver

matrix.org

Will you send logs?

No
@richvdh richvdh added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jul 6, 2022
@richvdh
Copy link
Member Author

richvdh commented Jul 6, 2022

We're planning to drop support for 3pid invite requests (via both POST /_matrix/client/v3/rooms/{roomId}/invite and POST /_matrix/client/v3/createRoom) without an id_access_token, because we need to know that a user has accepted the IS'es terms before we use it (cf matrix-org/synapse#13206, matrix-org/sydent#338).

@richvdh richvdh mentioned this issue Jul 6, 2022
Closed
@pixlwave pixlwave self-assigned this Jul 11, 2022
@pixlwave pixlwave mentioned this issue Jul 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixlwave pixlwave

Labels
A-Create-Room A-Invite T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include ID server access token in 3pid invites. matrix-org/matrix-ios-sdk
2 participants
@richvdh @pixlwave