Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Layout: Cancel and Back on Spaces Bottom Sheet #6572

Closed
daniellekirkwood opened this issue Aug 15, 2022 · 4 comments · Fixed by #6582
Closed

App Layout: Cancel and Back on Spaces Bottom Sheet #6572

daniellekirkwood opened this issue Aug 15, 2022 · 4 comments · Fixed by #6582
Assignees
@gileluard
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Delight Z-AppLayout

Comments

@daniellekirkwood
Copy link
Contributor

Your use case

There's too many buttons on the top-left of the bottom sheet

cancelbottomsheet

Have you considered any alternatives?

No response

Additional context

No response
@daniellekirkwood daniellekirkwood added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-AppLayout labels Aug 15, 2022
@amshakal
Copy link

Cancel shouldnt exist in this bottom sheet

@amshakal amshakal assigned gileluard and unassigned amshakal Aug 17, 2022
@gileluard
Copy link
Contributor

@amshakal the cancel button has been added accordingly with this issue. Should I remove the cancel button?

@amshakal
Copy link

Cancel should remain on the parent space switcher, just not when the user is navigating subspaces because then we need the back button

@gileluard
Copy link
Contributor

Fair enough :)

@gileluard gileluard mentioned this issue Aug 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gileluard gileluard

Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Delight Z-AppLayout
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

App Layout: Cancel and Back on Spaces Bottom Sheet element-hq/element-ios
3 participants
@gileluard @amshakal @daniellekirkwood