Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include concrete device model in user agent #6742

Closed
Johennes opened this issue Sep 19, 2022 · 0 comments · Fixed by #6761
Closed

Include concrete device model in user agent #6742

Johennes opened this issue Sep 19, 2022 · 0 comments · Fixed by #6761
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@Johennes
Copy link
Contributor

Your use case

For the upcoming device manager feature, we'd like to include the concrete device model, rather than just the e.g. "iPhone" so that it's easier for the user to differentiate between multiple similar devices.

Effectively this changes from e.g.

Riot/1.8.21 (iPhone; iOS 15.2; Scale/3.00)

to

Riot/1.8.21 (iPhone X; iOS 15.2; Scale/3.00)

Have you considered any alternatives?

No response

Additional context

No response
@Johennes Johennes added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Sep 19, 2022
Johennes added a commit to matrix-org/matrix-ios-sdk that referenced this issue Sep 20, 2022
@Johennes
Include concrete device model in user agent (PSG-754)
9695758 
Fixes: element-hq/element-ios#6742
@Johennes Johennes mentioned this issue Sep 20, 2022
Closed
3 tasks
Johennes added a commit that referenced this issue Sep 26, 2022
@Johennes
Include concrete device model in user agent (PSG-754)
ee1a2c8 
Fixes: #6742
@Johennes Johennes mentioned this issue Sep 26, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
1 participant
@Johennes