Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed various project warnings #5513

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Fixed various project warnings #5513

merged 1 commit into from
Feb 10, 2022

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Feb 7, 2022

The purpose of this PR is to fix most project warnings so that we can start relying on them again without all the noise and also improve Xcode's handling of them and beach balling.
One of the biggest problems is that most warnings get duplicated between all the 4 targets.

Changes:

  • increase swiftlint's warn limit for file lenght to 800. Error at 1000.
  • added WARNING_CFLAGS -Wno-nullability-completeness and OTHER_SWIFT_FLAGS -Wno-nullability-completeness to both Project-Warnings.xcconfig and the Podfile
  • Removed inaccesible ViewController from the main storyboard
  • Fixed incorrect documentation parameters
  • Fixed implicitly retaining self in blocks
  • Replaced some intentional deprecations with comments
  • Intentionally ignore deprecated declarations that have slim chances of getting fixed
  • Completely ignore Flex wranings as the library is debug only
  • Completely removed HPGrowingTextView as it's not necessary anymore

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YLUnYU

@SBiOSoftWhare SBiOSoftWhare self-requested a review February 9, 2022 16:13
@stefanceriu stefanceriu merged commit 4bd5c12 into develop Feb 10, 2022
@stefanceriu stefanceriu deleted the stefan/warning-fixes branch February 10, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants