Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started applying navigation bar theme styles to iOS 13 and 14 too. #5715

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu force-pushed the stefan/apply-nav-bar-style-iOS-13 branch from 85f24ac to 0b2902e Compare March 1, 2022 15:41
func applyStyle(onNavigationBar navigationBar: UINavigationBar,
withModernScrollEdgesAppearance modernScrollEdgesAppearance: Bool) {
navigationBar.tintColor = tintColor

// On iOS 15 use UINavigationBarAppearance to fix visual issues with the scrollEdgeAppearance style.
if #available(iOS 15.0, *) {
// On iOS 13+ use UINavigationBarAppearance to fix visual issues with the scrollEdgeAppearance style.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this comment is still only referring to iOS 15, as 13 & 14 don't have a scrollEdgeAppearance property.

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/DbQfPT

@stefanceriu stefanceriu force-pushed the stefan/apply-nav-bar-style-iOS-13 branch from 0b2902e to 442beb3 Compare March 1, 2022 16:11
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me 🤞

@stefanceriu stefanceriu merged commit e3d5550 into develop Mar 1, 2022
@stefanceriu stefanceriu deleted the stefan/apply-nav-bar-style-iOS-13 branch March 1, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants