NSE - Prevent playback on already read messages and enable on device …

[stefanceriu]

…silencing for unwanted push notifications

On device notification filtering is dependant on sygnal setting push_type = alert on notifications. An attempt at this was tried here but it's incomplete as voip pushes need another type/topic.

This PR now depends on matrix-org/matrix-ios-sdk#1500

[github-actions]

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/BRWEWr

[gileluard]

LGTM

[ismailgulek]

Had some comments after a static review. We'll need to test this after Sygnal task is done.

[ismailgulek]

LGTM!

[blau2]

Hi @stefanceriu, I was wondering if you would mind providing some additional context around why this change was made? Specifically, what does "playback" mean in this context? Beeper has forked the matrix-ios-sdk and we have gotten reports of users receiving notifications for very old messages when they login to their Matrix account on a new device. This PR looks like it would resolve this issue and I was wondering if it was a similar problem that prompted this fix. Thanks!

[stefanceriu]

Hey! This was in response to a security concern in which if somebody would get access to your credentials and phisical device they would be able to decrypt and display any message in notification popups by sending a new push request for an old message identifier. The fix basically just checks if a mesages was previously read and it if it was ignores the push.

[blau2]

Thanks Stefan, sounds like a different problem than what we're encountering but good to know!