Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measure performance in Sentry #6647

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Measure performance in Sentry #6647

merged 2 commits into from
Aug 31, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Aug 26, 2022

Implement startDurationTracking of MAnalyticsDelegate and send performance events to Sentry

@Anderas Anderas requested a review from a team August 26, 2022 15:37
@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

gileluard
gileluard approved these changes Aug 27, 2022
View reviewed changes
Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Nevertheless it seems StopDurationTracking cannot be found by the CI and that's why the CI's failing.

@Anderas
Copy link
Contributor Author

Anderas commented Aug 30, 2022

lgtm. Nevertheless it seems StopDurationTracking cannot be found by the CI and that's why the CI's failing.

Yea I ended up using different branch names for the SDK and client changes so its not automatically found. Will rebuild and merge this after the SDK change is merged

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/T7FgPV

@Anderas Anderas merged commit cc2115e into develop Aug 31, 2022
@Anderas Anderas deleted the andy/sentry_performance branch August 31, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gileluard gileluard gileluard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anderas @gileluard