Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeline items text height calculation #6702

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Sep 10, 2022

0A4CC072-FB26-4232-B927-62C67FA30B91

vs.

734D3764-7D99-4AD8-83F3-439CF86BF3DE

@sonarcloud
Copy link

sonarcloud bot commented Sep 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/mgA7kE

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2022

Codecov Report

Merging #6702 (b0a3777) into develop (d7ab536) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #6702   +/-   ##
========================================
  Coverage     9.88%    9.88%           
========================================
  Files         1474     1474           
  Lines       149841   149841           
  Branches     60504    60505    +1     
========================================
  Hits         14810    14810           
  Misses      134480   134480           
  Partials       551      551           
Impacted Files Coverage Δ
...ules/MatrixKit/Models/Room/MXKRoomBubbleCellData.m 16.14% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanceriu stefanceriu merged commit 8f9edde into develop Sep 11, 2022
@stefanceriu stefanceriu deleted the stefan/emojiLayoutFix branch September 11, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants