Fix navigation bars inside of VectorHostingController.

[pixlwave]

When building with Xcode 13, Element iOS running on iOS 16 has had some issues with the navigation bars not behaving as expected from SwiftUI. This appears to be twofold:

1. The .navigationBarHidden(true) modifier doesn't appear to work inside of VectorHostingController on presentation (it does however work when popping back to a screen with the modifier.
2. Using viewWillAppear to update the navigation controller with the custom isNavigationBarHidden appears to now occur before the hosting controller has been added to the navigation controller.

This PR sets the isNavigationBarHidden on screens that weren't using it and uses this property in viewWillLayoutSubviews.

The changelog is included in CHANGES.md ready for the release branch. Fixes #6738

Splash Screen Before	Splash Screen After	Congratulations Before	Congratulations After	Create Space Before	Create Space After

[stefanceriu]

lgtm 👍 ¯_(ツ)_/¯

[codecov]

Codecov Report

Base: 10.60% // Head: 10.58% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (aa46a20) compared to base (eda5861).
Patch coverage: 72.72% of modified lines in pull request are covered.

Additional details and impacted files

@@                    Coverage Diff                    @@
##           release/1.9.8/release    #6799      +/-   ##
=========================================================
- Coverage                  10.60%   10.58%   -0.02%     
=========================================================
  Files                       1504     1504              
  Lines                     151609   151613       +4     
  Branches                   61162    61163       +1     
=========================================================
- Hits                       16074    16053      -21     
- Misses                    134965   134991      +26     
+ Partials                     570      569       -1     

Impacted Files	Coverage Δ
...rompt/Coordinator/AnalyticsPromptCoordinator.swift	0.00% <0.00%> (ø)
...Coordinator/OnboardingCelebrationCoordinator.swift	0.00% <0.00%> (ø)
...dinator/OnboardingCongratulationsCoordinator.swift	0.00% <0.00%> (ø)
...dules/Common/SwiftUI/VectorHostingController.swift	75.00% <100.00%> (+2.63%)	⬆️
...oordinator/OnboardingSplashScreenCoordinator.swift	48.64% <100.00%> (+1.42%)	⬆️
Riot/Managers/Call/CallPresenter.swift	1.08% <0.00%> (-5.14%)	⬇️
Config/CommonConfiguration.swift	85.18% <0.00%> (-2.97%)	⬇️
Riot/Modules/Application/LegacyAppDelegate.m	13.40% <0.00%> (-0.34%)	⬇️
...xKit/Controllers/MXKAuthenticationViewController.m	18.95% <0.00%> (+1.91%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/4Wwwj6