Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra files in site-packages from wheel #3057

Merged
merged 2 commits into from
May 14, 2023

Conversation

jtilly
Copy link
Contributor

@jtilly jtilly commented May 13, 2023

Currently, when I install altair, I get a couple of extra files in my site-packages directory:

python -m env .env
pip install altair
cat .env/lib/python3.11/site-packages/README.md
cat .env/lib/python3.11/site-packages/LICENSE
cat .env/lib/python3.11/site-packages/pyproject.toml

These are all altair files. I think these files shouldn't be there 😉

This PR removes them.

Note: I'm no hatch expert, so I don't fully understand what the benefit of adding these files in tool.hatch.build is.

@binste
Copy link
Contributor

binste commented May 14, 2023

Thanks for bringing it up! Indeed, that shouldn't be the case :) You now excluded it from wheels which definitely makes sense, but do we need the files in the source distributions or can we directly remove the paths from INCLUDE? The license is stored in the .dist-info package anyway, see PEP 639:

image

and README and pyproject.toml might not need to be distributed at all? The README is also included automatically in .dist-info/METADATA. This would be in line with a few other packages I checked such as pandas.

@binste binste requested a review from mattijn May 14, 2023 07:30
@jtilly
Copy link
Contributor Author

jtilly commented May 14, 2023

I removed the files in question from the build altogether.

@mattijn mattijn merged commit 62ca5e3 into vega:master May 14, 2023
@mattijn
Copy link
Contributor

mattijn commented May 14, 2023

Thanks @jtilly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants