Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix CONTRIBUTING.md phrasing #3477

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Conversation

dangotbanned
Copy link
Member

The 2 later commits are a follow-up to #3461

Commits

  • docs: fix phrasing in Testing your Changes
  • docs: Use more consistent comments in Failures on specific python version(s)
    • These commands are referring to hatch environments named like hatch-test.py3.8, but not doc or default.
      • It is simpler to just describe this as python versions.
    • Also the hatch test docs refer to --python as accepting multiple versions, but do not give an example with more than one.
      • I've not figured out how this would work, so this keeps it simple.
  • docs: wrap long line

…rsion(s)*

These commands are referring to `hatch` environments named like `hatch-test.py3.8`, but not `doc` or `default`.
It is simpler to just describe this as python versions.

Also the [hatch test](https://hatch.pypa.io/latest/cli/reference/#hatch-test) docs refer to `--python` as accepting multiple versions, but do not give an example with more than one. I've not figured out how this would work, so this keeps it simple.
@dangotbanned
Copy link
Member Author

https:/vega/altair/actions/runs/9919793684/job/27406003297?pr=3477
mypy error will be resolved following #3475

Copy link
Contributor

@jonmmease jonmmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonmmease jonmmease merged commit 1ef4056 into vega:main Jul 13, 2024
11 checks passed
@dangotbanned dangotbanned deleted the fix-contrib-typo branch July 13, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants