Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 0000-Resign_Withdrawals #1121

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Create 0000-Resign_Withdrawals #1121

wants to merge 6 commits into from

Conversation

Vegaklaus
Copy link
Contributor

@Vegaklaus Vegaklaus commented Jun 13, 2022

First version of the resigning functionallity

Closes #1113 .

@davidsiska-vega
Copy link
Contributor

Spam protection: minimum withdrawal in multiples of quantum https:/vegaprotocol/specs-internal/blob/master/protocol/0027-ASSP-asset_proposal.md .

Transactions require a minimum value to be first created; thus, it is not possible to generfate 10^18 withdrawal requests using one Vega.

Withdrawal:
If a transaction is executed on Ethereum, the nonce used in this transaction is permanently stored, and no transaction with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stored on the ethereum chain

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this exists

- If above tests p[ass, all validators reset the bundle form their permanent data structure, verify the nonce matches the data, and issue a new signature on exactly that bundle.
- All else is done just as for the signing request (apart from the check for minimum value).

Question: What's the API currently ? Do we go via the chain or through direct communication ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know this is just a normal transaction "please give me a bundle" validators coordinate, create bundle and the result is emitted (event bus -> data node, it's public). @jeremyletang can confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-Sign Signature bundle
3 participants