Update from master

.github/workflows/quality_check.yml

@@ -51,3 +51,18 @@ jobs:
  files: .
  config_file: .github/workflows/config/markdownlint.json
  ignore_path: .github/workflows/config/markdownlintignore
+
+ checkcodes:
+ name: "Approbation"
+ runs-on: ubuntu-latest
+ steps:
+ - name: "Check out"
+ uses: actions/checkout@v3
+
+ - name: "Run Check AC codes"
+ run: |
+ npx github:vegaprotocol/approbation check-codes --specs="{./non-protocol-specs/**/*.md,./protocol/**/*.md}"
+
+ - name: "Run Check file names"
+ run: |
+ npx github:vegaprotocol/approbation check-filenames --specs="{./non-protocol-specs/**/*.md,./protocol/**/*.md}"

makefile

@@ -7,13 +7,13 @@ all: spellcheck markdownlint names codes references links clean
 .PHONY: names
 names:
  @$(MAKE) clone-sources
- npx @vegaprotocol/approbation check-filenames --specs="{./non-protocol-specs/**/*.md,./protocol/**/*.md}"
+ npx github:vegaprotocol/approbation check-filenames --specs="{./non-protocol-specs/**/*.md,./protocol/**/*.md}"
 
 # Count how many Acceptance Criteria each specification has
 .PHONY: codes
 codes:
  @$(MAKE) clone-sources
- npx @vegaprotocol/approbation check-codes --specs="{./non-protocol-specs/**/*.md,./protocol/**/*.md}"
+ npx github:vegaprotocol/approbation check-codes --specs="{./non-protocol-specs/**/*.md,./protocol/**/*.md}"
 
 TEMP=./.build
 .PHONY:clone-sources
@@ -44,7 +44,7 @@ clone-sources:
 references:
  @$(MAKE) clone-sources
 
- cd $(TEMP); npx -y @vegaprotocol/approbation@latest check-references --specs="../*protocol*/*.{md,ipynb}" --tests="./**/*.{js,py,feature}" --categories="../protocol/categories.json" --show-branches --show-mystery --verbose --show-files
+ cd $(TEMP); npx -y github:vegaprotocol/approbation@latest check-references --specs="../*protocol*/*.{md,ipynb}" --tests="./**/*.{js,py,feature}" --categories="../protocol/categories.json" --show-branches --show-mystery --verbose --show-files
 
 # Imperfect, but useful - hence not included in ALL
 .PHONY: links

protocol/0007-POSN-non_core_positions_api.md

@@ -12,6 +12,8 @@ The Position API provides access to net position per party per market. Specifica
 - Uses VW methodology to adjust the realised PnL resulting from any trade that caused volume to have been closed out. (<a name="0007-POSN-006" href="#0007-POSN-006">0007-POSN-006</a>)
 - Stores all traders’ realised PnL for every trade that caused volume to have been closed out. (<a name="0007-POSN-007" href="#0007-POSN-007">0007-POSN-007</a>)
 - Stores all traders' total realised PnL. (<a name="0007-POSN-008" href="#0007-POSN-008">0007-POSN-008</a>)
+- Stores a status field for all the traders, the status field will be set to ORDERS_CLOSED if a trader was distressed based on the margin requirements for their worst possible long/short, but their margin balance was sufficient to maintain their open position (i.e. their active orders will be removed from the book, after which the party was no longer distressed) (<a name="0007-POSN-015" href="#0007-POSN-015">0007-POSN-015</a>)
+- The status field will be set to CLOSED_OUT if the party was closed out (<a name="0007-POSN-016" href="#0007-POSN-016">0007-POSN-016</a>)
 
 ## Summary
 
@@ -58,6 +60,7 @@ The API is expected to expose:
 - When a party has a position which gets (partially) closed-out, the unrealised PnL should reflect the change of position while the realised PnL reflect the closed-out position (<a name="0007-POSN-011" href="#0007-POSN-011">0007-POSN-011</a>)
 - During settlement, all the parties' position should become 0, unrealised PnL should become 0 and realised PnL should update based on settlement price (<a name="0007-POSN-012" href="#0007-POSN-012">0007-POSN-012</a>)
 - If a party is subject to loss socialisation (its MTM gains get scaled down) the loss amount (forgone profit) should get recorded in realised PnL(<a name="0007-POSN-013" href="#0007-POSN-013">0007-POSN-013</a>)
+- If a party is subject to loss socialisation, the profits that could not be paid out due to loss socialisation is logged as "loss socialisation amount" which is accessible from API (<a name="0007-POSN-014" href="#0007-POSN-014">0007-POSN-014</a>)
 
 ## Definitions / glossary
 

protocol/0010-MARG-margin_orchestration.md

@@ -77,6 +77,11 @@ The protocol compares these levels to the balance in the trader's margin account
 | greater than _collateral release level_ | Collateral release | Collateral release
 | greater than _collateral search level_ and less than _initial margin_ | no action | No financial risk to network
 
+When posting a new order the initial margin for the overall position including the new order is calculated and order is only allowed to go ahead if party has enough funds to bring their margin account balance to that figure. An exception to this is when a party has an open position and tries to reduce it, but cannot afford the new margin. Then orders from the opposite side (short orders for a long position, long orders for a short position) are accepted as follows:
+
+- limit order: accept order when sum sizes of all the party's order's for that side of the book including the one being posted is less than or equal to the absolute open volume that a party has,
+- market order: accept order as long as its size is less than or equal to the absolute open volume that a party has.
+
 #### Collateral search
 
 When a trader's balance in their margin account (for a market) is less than their position’s collateral search level the protocol will attempt to transfer sufficient collateral from the trader’s main collateral account to top up their margin account to the level of the _initial margin_.

protocol/0012-POSR-position_resolution.md

@@ -8,7 +8,7 @@
 - Mark Price is never updated during position resolution (<a name="0012-POSR-004" href="#0012-POSR-004">0012-POSR-004</a>)
 - Non-distressed traders who trade with the network because their open orders are hit during the close out trade have their positions settled correctly. (<a name="0012-POSR-005" href="#0012-POSR-005">0012-POSR-005</a>)
 - When a distressed party has a [staking account](./0013-ACCT-accounts.md) with the same currency as the settlement currency of the market where it's distressed the staking account is NOT used in margin search and liquidation. (<a name="0012-POSR-006" href="#0012-POSR-006">0012-POSR-006</a>)
-- When a party is distressed at the point of leaving an auction it should get closed out immediately. (<a name="0012-POSR-007" href="#0012-POSR-007">0012-POSR-007</a>)
+- When a party is distressed at the point of leaving an auction it should get closed out as soon as the market returns to continuous trading mode and all the parked orders (pegged and LP) get added back to the order book. (<a name="0012-POSR-008" href="#0012-POSR-008">0012-POSR-008</a>)
 
 ## Summary